[JENKINS-49070] Avoid serializing BigDecimal and BigInteger in the model #239
Conversation
| val = val.doubleValue() | ||
| } else if (val instanceof BigInteger) { | ||
| if (val > Long.MAX_VALUE || val < Long.MIN_VALUE) { | ||
| errorCollector.error(ModelASTValue.fromConstant(-1, e), Messages.ModelParser_BigIntegerValue()) |
There was a problem hiding this comment.
Maybe converting to Double? The current impl is fine for me though
There was a problem hiding this comment.
Nah, I want to stick with int-family rather than floating point. Anyway, tweaked in latest commit.
|
|
||
| Object realVal = val.getValue(); | ||
|
|
||
| assertTrue(realVal instanceof Double); |
| if (val > Long.MAX_VALUE || val < Long.MIN_VALUE) { | ||
| errorCollector.error(ModelASTValue.fromConstant(-1, e), Messages.ModelParser_BigIntegerValue()) | ||
| } | ||
| val = -1 |
There was a problem hiding this comment.
Uh, I think this will convert, say, new BigInteger(42) to new Integer(-1) which is not what you meant to do. Looks like you meant to put this line inside the above }? Best to add a test confirming behavior of small integers.
There was a problem hiding this comment.
Whoops, yup. That -1 (when it's put in the right place!) ends up being ignored in practice, because the error trumps it, but yeah, it is in the wrong place.
There was a problem hiding this comment.
Oh, and this situation can only, in practice, be hit if you specify a constant number greater than Long.MAX_VALUE - we're only handling ConstantExpressions here, so, say, 24 ends up as functionally equivalent to new Integer(24), while 2147483648 (i.e., one more than Integer.MAX_VALUE) will be equivalent to new Long(2147483648). Groovy handles that behind the scenes.
|
Good idea. Lemme see how that goes. |
|
Ok, this is weird. I think it might be an environmental issue with Docker on the agents. I'll revisit this tomorrow or the weekend. |
0.1into aBigDecimal. So let's convert that to aDoubleinstead inModelASTValue#value. And also, just barf out if for some reason someone tries to use aBigIntegerconstant. Because no.