Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED JENKINS-56405] Use Docker registry when only URL is given #318

Merged
merged 2 commits into from Mar 6, 2019
Merged

[FIXED JENKINS-56405] Use Docker registry when only URL is given #318

merged 2 commits into from Mar 6, 2019

Conversation

abayer
Copy link
Member

@abayer abayer commented Mar 5, 2019

  • JENKINS issue(s):
  • Description:
    • registryUrl should be used even if no credentials are supplied.
  • Documentation changes:
    • n/a
  • Users/aliases to notify:
    • ...

kshultzCB
kshultzCB approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@kshultzCB kshultzCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@abayer abayer merged commit 4a3dd95 into jenkinsci:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@bitwiseman bitwiseman bitwiseman approved these changes

@kshultzCB kshultzCB kshultzCB approved these changes

@joseblas joseblas Awaiting requested review from joseblas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@abayer @dwnusbaum @bitwiseman @kshultzCB