Drop dependency on ASM #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin currently depends on ASM, provided by Jenkins core. We'd eventually like to drop ASM from Jenkins core and move it into a library plugin, so this PR prepares this plugin by dropping this plugin's dependency on ASM. The dependency was only used in one place for a constant, and since this constant is unlikely to ever change we can simply inline it.
Testing done
mvn clean verify -Dtest=InjectedTest,org.jenkinsci.plugins.pipeline.modeldefinition.parser.RuntimeASTTransformerTest