feat:Remove inline javascript code from Cloudbees workflow (#319)

* feat:Remove inline javascript code from Cloudbees workflow * feat:Remove inline javascript code from Cloudbees workflow Co-authored-by: Kevin Guerroudj <91883215+Kevin-CB@users.noreply.github.com> --------- Co-authored-by: Kevin Guerroudj <91883215+Kevin-CB@users.noreply.github.com>
jenkinsci · Oct 27, 2023 · 0b5fcd6 · 0b5fcd6
1 parent 5779a96
commit 0b5fcd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ui/src/main/resources/com/cloudbees/workflow/controller.jelly b/ui/src/main/resources/com/cloudbees/workflow/controller.jelly
@@ -9,7 +9,8 @@
             Optional fragment caption, passed through to the controller.
         </st:attribute>
     </st:documentation>
-    <script>var timeZone = '${it.timeZone}';</script>
+    <div id='timeparam' data-time='${it.timeZone}'/>
+    <st:adjunct includes="com.cloudbees.workflow.controllerScript"/>
     <div class="cbwf-stage-view">
         <div cbwf-controller="${name}" objectUrl="${rootURL}/${it.target.url}" fragCaption="${fragCaption}" />
         <st:adjunct includes="org.jenkinsci.pipeline.stageview_adjunct"/>

diff --git a/ui/src/main/resources/com/cloudbees/workflow/controllerScript.js b/ui/src/main/resources/com/cloudbees/workflow/controllerScript.js
@@ -0,0 +1 @@
+var timeZone = document.querySelector('#timeparam').dataset.time;