Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #299

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 6, 2023
@timja timja requested a review from a team June 9, 2023 21:32
@olamy olamy merged commit 6431bea into jenkinsci:master Jun 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
3 participants