Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize popup window size for using screen estate #41

Closed
wants to merge 1 commit into from

Conversation

ssbarnea
Copy link

@ssbarnea ssbarnea commented May 24, 2017

@svanoort
Copy link
Member

Thank you for submitting this! It looks very appealing, but please can you include a screenshot of the result?

Will need to do some manual testing at a variety of resolutions and browsers to verify if this works correctly in all the cases, so may be a while before I can get back with a clear mergeable/changes needed result.

@ssbarnea
Copy link
Author

I am still working on polishing this as I found some problems during testing. I will be back with updates and screenshots! Everyone loves them :)

@svanoort
Copy link
Member

svanoort commented Sep 5, 2017

@ssbarnea Did you ever get this to where you're happy with it? I'm doing a sweep through PRs this week to try to get everything tested/merged, and this would be a good candidate for the next release.

@ssbarnea
Copy link
Author

ssbarnea commented Sep 5, 2017

@svanoort Thanks for pinging me on this as I didn't do anything on it due to other priorities. But your sale point convinced me to spend an extra hour or two and fix it.

Sadly I need to test it again because I remember that I found some kind of bug.

@svanoort
Copy link
Member

@ssbarnea Any word on this change? Still looking to include it into a release

@ssbarnea
Copy link
Author

Sorry but I didn't had time to fix it and from tomorrow I will be in vacation, without internet so I think it would be better if someone can take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants