Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer non-wildcard imports, even for tests #1165

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Prefer non-wildcard imports, even for tests #1165

merged 1 commit into from
Oct 21, 2023

Conversation

MarkEWaite
Copy link
Contributor

Prefer non-wildcard imports, even for tests

Thanks to OpenRewrite for providing the beginning of this change.

https://docs.openrewrite.org/recipes/java/testing/junit5/usehamcrestassertthat was the beginning of the change.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Tests

@MarkEWaite
Prefer non-wildcard import, even for tests
ec31397 
Thanks to OpenRewrite for providing the beginning of this change.

https://docs.openrewrite.org/recipes/java/testing/junit5/usehamcrestassertthat
was the beginning of the change.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 21, 2023 16:02
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Oct 21, 2023
@github-actions github-actions bot removed the tests Automated test addition or improvement label Oct 21, 2023
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Oct 21, 2023
@MarkEWaite MarkEWaite merged commit 385abbd into jenkinsci:master Oct 21, 2023
15 checks passed
@MarkEWaite MarkEWaite deleted the prefer-non-wildcard-import branch October 21, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Automated test addition or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MarkEWaite