Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-64324] Truncate version label at first slash #234

Merged
merged 1 commit into from Nov 27, 2020
Merged

[JENKINS-64324] Truncate version label at first slash #234

merged 1 commit into from Nov 27, 2020

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Nov 27, 2020 •
edited

JENKINS-64324 - Fix Debian testing label to not include '/'

The Debian testing distribution seems to have changed its lsb_release output to now report the release as "testing/unstable" rather than "testing" as was reported previously. That exposes a bug in Jenkins that it is not always well behaved with agent labels that include the '/' character.

This pull request truncates the automatically generated label at the first '/' character. The automatic label assigned to Debian testing will be testing even though the output of lsb_release -r looks like this:

$  lsb_release -r
Release:        testing/unstable

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@MarkEWaite
[JENKINS-64324] Truncate version label at first slash
2d7c365 
The Debian testing distribution seems to have changed its `lsb_release`
output to now report the release as "testing/unstable" rather than
"testing" as was reported previously.  That exposes a bug in Jenkins
that it is not always well behaved with agent labels that include the
'/' character.
@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Nov 27, 2020
@MarkEWaite MarkEWaite merged commit ebf6d41 into jenkinsci:master Nov 27, 2020
@MarkEWaite MarkEWaite deleted the fix-debian-testing-label branch November 27, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MarkEWaite