-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security warnings should be shown by default #258
Labels
good first issue
Good for newcomers
Comments
Hi Mark, My approach would be:
Do you think it sounds good? |
jiakuanghe
pushed a commit
to jiakuanghe/plugin-installation-manager-tool
that referenced
this issue
Feb 1, 2023
6 tasks
jiakuanghe
pushed a commit
to jiakuanghe/plugin-installation-manager-tool
that referenced
this issue
Feb 14, 2023
…ngs is false, and --view-security-warnings is true by default (jenkinsci#258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
plugin-installation-manager-tool/plugin-management-cli/src/main/java/io/jenkins/tools/pluginmanager/cli/CliOptions.java
Lines 77 to 80 in 79b38b4
There seems to be no real reason for this to be disabled by default.
--view-security-warnings
should be made a no-op for compatibility, and a new option--hide-security-warnings
(or similar) should be added to explicitly opt out of showing them.The text was updated successfully, but these errors were encountered: