Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security warnings should be shown by default #258

Closed
daniel-beck opened this issue Jan 17, 2021 · 1 comment · Fixed by #522
Closed

Security warnings should be shown by default #258

daniel-beck opened this issue Jan 17, 2021 · 1 comment · Fixed by #522
Labels
good first issue Good for newcomers

Comments

@daniel-beck
Copy link
Member

@Option(name = "--view-security-warnings",
usage = "Show if any security warnings exist for the requested plugins",
handler = BooleanOptionHandler.class)
private boolean showWarnings;

There seems to be no real reason for this to be disabled by default.

--view-security-warnings should be made a no-op for compatibility, and a new option --hide-security-warnings (or similar) should be added to explicitly opt out of showing them.

@MarkEWaite MarkEWaite added the good first issue Good for newcomers label Jan 27, 2023
@jiakuanghe
Copy link
Contributor

Hi Mark,
@MarkEWaite I am planning to fix this issue.

My approach would be:

  1. By default, the security warnings will display to the user. Although the user didn't use the option (--view-security-warnings), the result would still show.
  2. Add a new option (--hide-security-warnings). For the users who want to hide the warnings.
  3. Update the document in README.md
    3.1 Mark --view-security-warnings as deprecated
    3.2 Add option --hide-security-warnings

Do you think it sounds good?

jiakuanghe pushed a commit to jiakuanghe/plugin-installation-manager-tool that referenced this issue Feb 1, 2023
jiakuanghe pushed a commit to jiakuanghe/plugin-installation-manager-tool that referenced this issue Feb 14, 2023
…ngs is false, and --view-security-warnings is true by default (jenkinsci#258)
MarkEWaite pushed a commit that referenced this issue Mar 3, 2023
* Security warnings will be shown by default (#258)

* Improve default security warnings settings: --view-all-security-warnings is false, and --view-security-warnings is true by default (#258)

---------

Co-authored-by: Sam <sam2008ext@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants