-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not iterate through transient plugin dependencies if a newer dependency version is explicitly defined in the plugin list #102
Conversation
@@ -0,0 +1,60 @@ | |||
ace-editor:1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused at the moment
...-library/src/test/java/io/jenkins/tools/pluginmanager/impl/PluginManagerIntegrationTest.java
Outdated
Show resolved
Hide resolved
...-library/src/test/java/io/jenkins/tools/pluginmanager/impl/PluginManagerIntegrationTest.java
Outdated
Show resolved
Hide resolved
It will take a while to finish my patch. I will cut the release from the master branch for now |
…there is a higher-version dependency resolved
I applied a partial fix which kinda works for dependencies explicitly declared in plugins.txt or plugin.yml . It will still be an issue for dependency conflicts in the dependency tree |
plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
Outdated
Show resolved
Hide resolved
…nmanager/impl/PluginManager.java
@@ -721,74 +721,6 @@ public void downloadPluginsUnsuccessfulTest() throws IOException { | |||
pluginManagerSpy.downloadPlugins(plugins); | |||
} | |||
|
|||
@Test | |||
public void findPluginsAndDependenciesTest() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to the integration test which does not use Mocking
} else { | ||
String message = String.format("Plugin %s:%s depends on %s:%s, but there is an older version defined on the top level - %s:%s", | ||
plugin.getName(), plugin.getVersion(), p.getName(), p.getVersion(), pinnedPlugin.getName(), pinnedPlugin.getVersion()); | ||
// TODO(oleg_nenashev): Should be an error by default, but it is not how the tests are written now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO there should be an error by default, but it is not how the tests are written now
Skipping it for now, original test from @stopalopa will fail
Currently the tool checks for older transient dependency versions even if a newer one is explicitly defined in a plugin source. Fixes #101
Leads to....
Fixes #101