Add command line flag for overriding plugin info location + document proxy configuration #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL to plugin-versions.json is hard-coded unlike all other URLs. This commit also updates the readme to provide guidance for people in a highly locked down corporate environment.
In addition to being easier for everyone this is particularly helpful behind a corporate proxy where connecting to the non-standard maven repository https://repo.jenkins-ci.org/public/ can be challenging.
timja
reviewed
Jun 27, 2020
README.md
Outdated
| #### Proxy Support | ||
| Proxy support is available using standard [Java networking system properties](https://docs.oracle.com/javase/7/docs/api/java/net/doc-files/net-properties.html) `http.proxyHost` and `http.proxyPort`. Note that this provides only basic NTLM support and you may need to use an authentication proxy like [CNTLM](https://sourceforge.net/projects/cntlm/). | ||
|
|
||
| If you are behind a corporate proxy using a self-signed certificate you may wish to use the http variants of the default urls. The full list is given below for convenience. |
There was a problem hiding this comment.
I don’t think recommending http is a good idea, it’ll likely break at some point when https in enforced.
timja
approved these changes
Jun 27, 2020
timja
changed the title
timja
added
documentation
timja
changed the title
timja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the tool. We too have created something similar and I would like to delete ours and use this instead. I have only just started experimenting, this PR contains what I needed in terms of code patches and some documentation that would have shaved hours off the time it took me to work this all out.
In summary:
DEFAULT_PLUGIN_INFO_LOCATIONto be overridden via cli and env like the other URLs.