Updated jenkins.war default path for linux

[itsAftabAlam]

Fixes #427
Fixes #520

This PR changed the default jenkins.war location for OS other than windows to usr/share/java/jenkins.war

Operating System used

Linux: Ubuntu

Issue Reproduction Steps

Same as described in the issue description

Expected Result is Achieved

plugin installation manager tool finds jenkins.war at the default path and is able to get the Jenkins version from it.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[krisstern]

Hi @itsAftabAlam, we already have an active PR at #520.

[timja]

Hi @itsAftabAlam, we already have an active PR at #520.

the other one is a lot more complex for what is really a simple change, this one can be shipped

[krisstern]

Okay

[MarkEWaite]

the other one is a lot more complex for what is really a simple change, this one can be shipped

Won't this surprise users that were relying on the old location as the default? Do we need more text describing the change in the changelog?

[itsAftabAlam]

Greetings @MarkEWaite. Just curious if updating PR heading updates changelog as well? If so, I can do so. I had updated the default war file path after taking a look on jenkinsci/packaging#266 & JENKINS-41218 mentioned in issue #427 , may we can mention that in the changelog?

[krisstern]

Won't this surprise users that were relying on the old location as the default? Do we need more text describing the change in the changelog?

Yes @MarkEWaite I agree that this may come as a surprise to some users.

[MarkEWaite]

Greetings @MarkEWaite. Just curious if updating PR heading updates changelog as well?

Once the release has been published, release drafter does not perform any additional updates.

I had updated the default war file path after taking a look on jenkinsci/packaging#266 & JENKINS-41218 mentioned in issue #427 , may we can mention that in the changelog?

I think that is a good idea. I've added a link to the Jira issue in the changelog. That provides some additional context for the change of default location

[dominykas]

The official Docker image for Jenkins has the WAR file in the old location. This means that interacting with the jenkins-plugin-cli now always prints War not found, installing all plugins: /usr/share/java/jenkins.war. Not sure exactly where this issues should be addressed, but I would guess that changing the path inside the official image would be quite a breaking change for people?

[timja]

Looks like #520 should be re-evaluated. Unsure how much of a pain it would be to change the location in the image, it was changed for linux packages without any complaints I think.