[JENKINS-59148] Add option for getting all of the latest dependencies #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slide
approved these changes
Sep 13, 2019
timja
approved these changes
Sep 13, 2019
| private boolean useLatest; | ||
| private boolean useLatestSpecified; | ||
|
|
||
| @Option(name = "--latest-all", usage = "Set to true to download the latest version of all dependencies, even " + |
There was a problem hiding this comment.
could this be the latest option? this is what I would expect when I ask for latest.
it's also what I would probably expect by default really. but debatable and personal preference
Suggested change
| @Option(name = "--latest-all", usage = "Set to true to download the latest version of all dependencies, even " + | |
| @Option(name = "--latest", usage = "Set to true to download the latest version of all dependencies, even " + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-59148
Based off of feedback from Oleg, the current functionality of having all dependencies be on the latest version should also be supported since that's how the install-plugins bash script is currently working.