Add caching of downloaded plugins + remove -plugin retry hack + fix master #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
May 17, 2020
| } | ||
|
|
||
| try (CloseableHttpClient httpclient = HttpClients.custom().useSystemProperties() | ||
| .addInterceptorLast((HttpRequestInterceptor) (request, context) -> { | ||
| throw new IOException("Retry on any failure"); |
There was a problem hiding this comment.
this was always causing an exception to be thrown before, which meant every request was retried and then it failed after 3 times
slide
reviewed
May 17, 2020
plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
Show resolved
Hide resolved
slide
reviewed
May 17, 2020
| try { | ||
| Files.createDirectories(refDir.toPath()); | ||
| FileUtils.deleteDirectory(refDir); |
There was a problem hiding this comment.
What if there are already plugins in the ref dir? Some people copy plugins into the refDir and then run the install plugins to add additional ones from the update center. This would not allow that usage case.
There was a problem hiding this comment.
Do it after the install plugins runs?
There was a problem hiding this comment.
Its either that or we need to download plugins somewhere else and then move them when completed, but this is definitely the easiest fix on our side
slide
reviewed
May 19, 2020
plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
Outdated
Show resolved
Hide resolved
eyonasi
approved these changes
May 27, 2020
jetersen
approved these changes
Jun 3, 2020
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.