Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting source and target are unnecessary when setting release #530

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Setting source and target are unnecessary when setting release #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,9 +945,16 @@
<jdk>[1.9,)</jdk>
</activation>
<properties>
<!-- When compiling with a Java 9+ compiler, we always rely on "release" in favor of "source" and "target", even when compiling to Java 8 bytecode. -->
<maven.compiler.release>8</maven.compiler.release>
<maven.compiler.testRelease>8</maven.compiler.testRelease>
<!-- "release" serves the same purpose as Animal Sniffer. -->
<animal.sniffer.skip>true</animal.sniffer.skip>
<!-- While it does not hurt to have these set to the Java specification version, it is also not needed when "release" is in use. -->
<maven.compiler.source combine.self="override" />
<maven.compiler.target combine.self="override" />
<maven.compiler.testSource combine.self="override" />
<maven.compiler.testTarget combine.self="override" />
<!-- Work around openjdk/jdk11u-dev#919. TODO When we upgrade to OpenJDK 11.0.16, this should be deleted. -->
<maven.compiler.forceJavacCompilerUse>true</maven.compiler.forceJavacCompilerUse>
</properties>
Expand Down