Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate java.level #245

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Deprecate java.level #245

merged 1 commit into from
Mar 31, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 31, 2022

Like jenkinsci/plugin-pom#522 but for pom rather than plugin-pom.

Deployment plan: There are only a dozen or so core components, so I plan on just making a pass through them as I upgrade to this release of pom and deleting java.level manually.

@basil basil requested a review from jglick March 31, 2022 00:13
@basil
Copy link
Member Author

basil commented Mar 31, 2022

In case you're wondering, Jesse, I am considering trying to adapt the new Initializer mojo to be callable from e.g. core and jenkins-test-harness (e.g. so that we can get the benefits of #324 not just in plugins but in core components, which we'll need to test the Insane upgrade in jenkins-test-harness for example). Anyway, I haven't gotten that far yet but this PR is the first step in that direction.

@jglick
Copy link
Member

jglick commented Mar 31, 2022

the benefits of #324

jenkinsci/maven-hpi-plugin#324 you mean?

@jglick
Copy link
Member

jglick commented Mar 31, 2022

Removing this property here should help simplify 11 migration work, but do note that core components do not follow the same logic as plugins when it comes to Java version requirements vs. the minimum Java version of core: they are upgraded by core developers, rather than by end users.

@basil
Copy link
Member Author

basil commented Mar 31, 2022

do note that core components […] are upgraded by core developers, rather than by end users

I am a core developer who performed a large number of such upgrades recently. Did you think I did not know this?

@basil basil merged commit af83629 into jenkinsci:master Mar 31, 2022
@basil basil deleted the java-level branch March 31, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants