Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate SpotBugs defaults #333

Merged
merged 2 commits into from Nov 2, 2022
Merged

Remove duplicate SpotBugs defaults #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f011d8
Remove duplicate SpotBugs defaults
basil Nov 2, 2022
0c2020e
Merge branch 'master' into spotbugs-defaults
basil Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 0 additions & 18 deletions pom.xml
View file
Open in desktop
Expand Up @@ -93,19 +93,6 @@
-->
<spotbugs.omitVisitors>FindReturnRef</spotbugs.omitVisitors>

<!-- Whether the build should fail if SpotBugs finds any error. -->
<!-- It is strongly encouraged to leave it as true. Use false with care only in transient situations. -->
<spotbugs.failOnError>true</spotbugs.failOnError>
<!-- Defines a SpotBugs threshold. Use "Low" to discover low-priority bugs.
Hint: SpotBugs considers some real NPE risks in Jenkins as low-priority issues, it is recommended to enable it in plugins.
-->
<spotbugs.threshold>Medium</spotbugs.threshold>
<!-- Defines a SpotBugs effort. Use "Max" to maximize the scan depth -->
<spotbugs.effort>default</spotbugs.effort>
<!-- Defines an optional SpotBugs excludes file.
Generally it is recommended to use @SuppressFBWarnings annotation unless you want to ignore an entire class of issues -->
<spotbugs.excludeFilterFile />

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<project.build.outputEncoding>UTF-8</project.build.outputEncoding>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -688,13 +675,8 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<failOnError>${spotbugs.failOnError}</failOnError>
<xmlOutput>true</xmlOutput>
<spotbugsXmlOutput>false</spotbugsXmlOutput>
<effort>${spotbugs.effort}</effort>
<threshold>${spotbugs.threshold}</threshold>
<!-- Empty by default, child POMs are expected to override if needed -->
<excludeFilterFile>${spotbugs.excludeFilterFile}</excludeFilterFile>
<plugins>
<plugin>
<groupId>com.h3xstream.findsecbugs</groupId>
Expand Down