[JENKINS-40284] - Fix blocked weights with FQ strategies #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debanne
force-pushed
the
fix_blocked_fq_weights
branch
2 times, most recently
from
31e9a6b
to
4b96638
Compare
when a weight reached 1.00005 for instance, it was never increased due to the comparison on floats. Also, the weight was no more increased when the step became too small compared to the minimum weight. As we are not using integers but floats, the step must remain proportional to the weight.
Note that it is quite hypothetical that it will occure in production, given the value of Float.MAX_VALUE.
debanne
force-pushed
the
fix_blocked_fq_weights
branch
from
4b96638
to
16f901b
Compare
|
@jenkinsci/code-reviewers |
|
LGTM 👍 |
|
👍 |
|
@oleg-nenashev @emsa23 do you thing you could merge this PR and release the plugin? |
|
I can |
oleg-nenashev
changed the title
MarkEWaite
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a weight reached 1.00005 for instance, it was never increased
due to the comparison on floats.
Also, the weight was no more increased when the step became too small
compared to the minimum weight. As we are not using integers but
floats, the step must remain proportional to the weight.