forked from lsjostro/prometheus-plugin
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV Variable for collecting diskusage #241
Merged
markjacksonfishing
merged 28 commits into
jenkinsci:master
from
bashbers:feature/SDP-2908-disable-diskusage-check
Apr 8, 2021
Merged
ENV Variable for collecting diskusage #241
markjacksonfishing
merged 28 commits into
jenkinsci:master
from
bashbers:feature/SDP-2908-disable-diskusage-check
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collectDiskUsage
…aultcollectdiskusage
…in constructor with null in order to kickstart getting the env variable
…the ENV variable correctly inside CollectDiskUsage
…ing collect_disk_usage
bashbers
changed the title
Feature/sdp 2908 disable diskusage check
ENV Variable for Disable diskusage plugin
Apr 8, 2021
bashbers
changed the title
ENV Variable for Disable diskusage plugin
ENV Variable for collecting diskusage
Apr 8, 2021
Seems to only log the error once now with the ENV set to false. |
markjacksonfishing
approved these changes
Apr 8, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes logging errors inside a cloud storage environment with virtually unlimited storage.
Changes proposed
COLLECT_DISK_USAGE
)COLLECT_DISK_USAGE
in the Jenkins frontend.Checklist
Note: I would squash merge this PR.
Notify
@markyjackson-taulia