Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV Variable for collecting diskusage #241

Conversation

bashbers
Copy link

@bashbers bashbers commented Apr 8, 2021

Fixes logging errors inside a cloud storage environment with virtually unlimited storage.

Changes proposed

  • ENV Variable which allows the user to decide if the plugin should gather disk usage or not (COLLECT_DISK_USAGE)
  • New test case which tests the usage of the ENV variable.
  • New checkbox inside the jelly config which allows the enduser to enable or disable COLLECT_DISK_USAGE in the Jenkins frontend.

Checklist

  • Includes tests covering the new functionality?
  • Ready for review
  • Follows CONTRIBUTING rules

Note: I would squash merge this PR.

Notify

@markyjackson-taulia

Bersselaar, B. van den (Brian) added 27 commits April 1, 2021 16:22
…in constructor with null in order to kickstart getting the env variable
…the ENV variable correctly inside CollectDiskUsage
@bashbers bashbers changed the title Feature/sdp 2908 disable diskusage check ENV Variable for Disable diskusage plugin Apr 8, 2021
@bashbers bashbers changed the title ENV Variable for Disable diskusage plugin ENV Variable for collecting diskusage Apr 8, 2021
@bashbers bashbers marked this pull request as draft April 8, 2021 09:56
@bashbers bashbers closed this Apr 8, 2021
@bashbers bashbers reopened this Apr 8, 2021
@bashbers
Copy link
Author

bashbers commented Apr 8, 2021

Seems to only log the error once now with the ENV set to false.
This is acceptable as it doesn't flood the log file anymore.

@bashbers bashbers marked this pull request as ready for review April 8, 2021 10:54
@markjacksonfishing markjacksonfishing merged commit f38baa9 into jenkinsci:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants