Disable DiskUsageCollector when its option is unchecked (JENKINS-66790)

[agabrys]

Fixes JENKINS-66790.

Changes proposed

The DiskUsageCollector class uses the ConfigurationUtils#getCollectDiskUsage method to determine whether the disk usage statistics should be collected or not. Unfortunately, the mentioned method ignores the checkbox configuration option available on the Configure System page. The PrometheusConfiguration class keeps the requested value in the collectDiskUsage field which is set with the default value if needed. The ConfigurationUtils#getCollectDiskUsage method is removed and the PrometheusConfiguration#getCollectDiskUsage method is used instead.

The PrometheusConfiguration#getDefaultCollectDiskUsage method is no longer used, so it has been removed too.

Checklist

• Includes tests covering the new functionality?
• Ready for review
• Follows CONTRIBUTING rules

Notify

@markyjackson-taulia

[agabrys]

I'll be able to test the changes right after I get information how to build the project without any issues (read more: #337 (comment)).

[agabrys]

@markyjackson-taulia please, take a look. If you agree with changes, it would be great to release a new version of the plugin after the merge.

[markjacksonfishing]

I agree with the change and will do a release tomorrow night

[agabrys]

@markyjackson-taulia could you provide ETA when it should be available?

[markjacksonfishing]

My hope is tomorrow. I am currently on a business trip

[markjacksonfishing]

@agabrys Pr has been approved and merged. Release has started and it will take several hours for it to become available in the update center.

Thank you for this work and your patients.

[markjacksonfishing]

Running into test errors: https://pastebin.com/vQi71zNS

cc @agabrys

[agabrys]

The plugin should be built with Java 8, but Java 17 is used:

[...]
module java.base does not "opens java.util" to unnamed module @4d937939
[...]
[INFO] JDK Version: 17.0.2 normalized as: 17.0.2
[...]

[markjacksonfishing]

@agabrys thanks for catching that. I must have changed and forgot to put that back.
Plugin has been released, give it a few hours to show up in the update center.

 [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time:  32.353 s
    [INFO] Finished at: 2022-03-07T14:25:18-08:00
    [INFO] ------------------------------------------------------------------------
[INFO] Cleaning up after release...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  43.319 s
[INFO] Finished at: 2022-03-07T14:25:18-08:00
[INFO] ------------------------------------------------------------------------