Reviews from James

jenkinsci · Feb 8, 2022 · c1fc223 · c1fc223
1 parent 8bd4568
commit c1fc223
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -20,10 +20,10 @@
     <changelist>-SNAPSHOT</changelist>
     <gitHubRepo>jenkinsci/promoted-builds-plugin</gitHubRepo>
     <bom>2.289.x</bom>
-    <jenkins.version>2.289.3</jenkins.version>
+    <jenkins.version>2.289.1</jenkins.version>
     <java.level>8</java.level>
     <findbugs.effort>Max</findbugs.effort>
-    <hpi.compatibleSinceVersion>3.0</hpi.compatibleSinceVersion>
+    <hpi.compatibleSinceVersion>4.0</hpi.compatibleSinceVersion>
   </properties>
 
   <developers>

diff --git a/src/main/java/hudson/plugins/promoted_builds/Promotion.java b/src/main/java/hudson/plugins/promoted_builds/Promotion.java
@@ -96,8 +96,7 @@ public AbstractBuild<?,?> getTargetBuild() {
      */
     @Nonnull
     public AbstractBuild<?,?> getTargetBuildOrFail() {
-        PromotionTargetAction pta = getAction(PromotionTargetAction.class);
-        final AbstractBuild<?, ?> target = pta == null ? null : pta.resolve(this);
+        final AbstractBuild<?, ?> target = getTargetBuild();
         if (target == null) {
             throw new IllegalStateException("There is no target build associated with " + this +
                     ". Most probably, the build has been already removed");