Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable changing parameter value for promotion re-execution #27

Closed
wants to merge 3 commits into from
Closed

enable changing parameter value for promotion re-execution #27

wants to merge 3 commits into from

Conversation

cvarjao
Copy link
Contributor

@cvarjao cvarjao commented Jun 9, 2013

This is my first pull request. Comments are definitely appreciated.

  • Move parameter values form ManualCondition.Badge to the promotion build as PromotionParametersAction. I decide to keep it separate from ParametersAction just to keep the original build separated for compatibility (perhaps unnecessary?).
  • The index.jelly for the ManualCondition.Badge change to list the parameters from the last promotion, and allow editing the values.

https://issues.jenkins-ci.org/browse/JENKINS-8962

@buildhive
Copy link

Jenkins » promoted-builds-plugin #42 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

Jenkins » promoted-builds-plugin #43 SUCCESS
This pull request looks good
(what's this?)

@cvarjao
Copy link
Contributor Author

cvarjao commented Jun 9, 2013

Please disregard this request. I will re-submit again later after bringing up to the governance document.

@cvarjao cvarjao closed this Jun 9, 2013
@cvarjao
Copy link
Contributor Author

cvarjao commented Jul 25, 2013

new pull request -> #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cvarjao @buildhive