JENKINS-29358 - fix history, latest build, promotions

[hangie]

The first build was being returned instead of the latest.
History was showing first 10 instead of last 10.
Promotions column had incorrect build number against promotions.

• https://issues.jenkins-ci.org/browse/JENKINS-36391
• https://issues.jenkins-ci.org/browse/JENKINS-29358

[oleg-nenashev]

Are you planning to propose a new version?

[hangie]

Hi,

Builds have been failing for a while, unrelated to my change, so might be difficult. I've used this plugin a bit and was getting frustrated with the incorrect information displaying. Thought I'd have a crack at fixing it. Since it seems to be working nicely I figured I'd post it back for others.

I've closed the request currently and have had a look at the failures. Not sure what's causing it 😢.

Cheers,
Mark.

On 23 May 2016, at 4:01 PM, Oleg Nenashev notifications@github.com wrote:

Are you planning to propose a new version?

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

[hangie]

Is there a resource issue with the builds? It seems that tests are killed for some reason, but I can't see why. All builds appear to be failing, just to a different degree. Is there some way to find out what is going on? The console log doesn't appear to be helpful.

[rotem925]

why is this closed?
I've compiled the code and its run perfectly with your changes

[hangie]

I closed it as I figured I hadn't followed the process correctly. So I was going to read up on how to contribute and then bring it back. Builds have been failing for ages, so difficult to integrate easily.

[rotem925]

Ok, Great! thanks for the reply.
This kind of fail already happens before, I feel like this need a unit test.

[hangie]

What is required to get this merged?

[rotem925]

Can someone please give us a status on this? this is a very major issue.

[hangie]

I'd like to see this back into the standard plugin so I can stop using my own version. Not sure what more is required of me. The builds fail for reasons unrelated (haven't passed for ages).

If it can be reviewed and any required actions on my end advised I'll do what I need to allow this to progress...

Cheers,
Mark.

On 4 Jul. 2016, at 7:36 pm, Rotem notifications@github.com wrote:

Can someone please give us a status on this? this is a very major issue.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[oleg-nenashev]

The ball is actually on my side :(

[oleg-nenashev]

But yes, this fix LGTM. Needs some polishing and tests, but it's a TODO on the maintainer side in this case

[hangie]

Thanks.

Happy to help if I can, just let me know what it is and I'll give it a go 😃.

Cheers,
Mark.

On 4 Jul. 2016, at 11:34 pm, Oleg Nenashev notifications@github.com wrote:

The ball is actually on my side :(

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[oleg-nenashev]

Fixes https://issues.jenkins-ci.org/browse/JENKINS-36391