Skip to content

Commit

Permalink
Cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
Lauri Pajunen committed Feb 5, 2018
1 parent 821e66f commit 7f85c49
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
Expand Up @@ -17,6 +17,7 @@

/**
* TODO, is this actually needed. Check whether this can be integrated to StreamRequestBody
* Though it should be remembered that stream != file.
*/
public class ReadableFile {
@Getter @Setter private FilePath filePath = null;
Expand Down
Expand Up @@ -23,7 +23,7 @@
import java.util.regex.Pattern;

// TODO: Change this to something like instantiable FileGetter or something. static isn't very nice.
// We need to moce the regexps, logger and such through multiple methods and that's not good.
// We need to move the regexps, logger and such through multiple methods and that's not good.
// Of course the truly atomic helpers can be left alone.
public class UtilitiesFile {

Expand Down
Expand Up @@ -11,7 +11,6 @@
package com.synopsys.protecode.sc.jenkins;

import com.synopsys.protecode.sc.jenkins.types.InternalTypes.ConnectionStatus;
import hudson.model.TaskListener;
import okhttp3.Headers;

class UtilitiesGeneral {
Expand Down
Expand Up @@ -21,7 +21,9 @@
import java.util.logging.Logger;
import jenkins.model.Jenkins;


/**
* Utility for Jenkins related functionality.
*/
public final class UtilitiesJenkins {

private static final Logger LOGGER = Logger.getLogger(UtilitiesJenkins.class.getName());
Expand All @@ -48,7 +50,7 @@ public static StandardUsernamePasswordCredentials getCredentials(
Jenkins.getInstance(), ACL.SYSTEM,
new HostnameRequirement(url.toExternalForm())),
CredentialsMatchers.withId(credentialsId));
LOGGER.log(Level.ALL, "Creds: {0}", creds);
LOGGER.log(Level.FINE, "Creds: {0}", creds);
return creds;
}
}

0 comments on commit 7f85c49

Please sign in to comment.