Adding optional description to slave #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I do wish there were automated tests for this, but I don't have a good suggestion for how to write those in a non-insane fashion :) |
rtyler
pushed a commit
that referenced
this pull request
Jun 26, 2015
Adding optional description to slave
|
@rtyler unit tests can inspect the interpolated template and acceptance tests could look at the installed init script or the process title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you created a slave using this manifest, it would show up in the master as something like
Slave MyNewSlave (Swarm slave from 192.168.0.10 : null). This pull request allows you to specify a description to put in place of the 'null'.