Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use page transition for purge command #31

Merged
merged 4 commits into from Jun 7, 2022

Conversation

fredg02
Copy link
Member

@fredg02 fredg02 commented Jun 4, 2022

See https://issues.jenkins.io/browse/JENKINS-21674

Copying the behavior from project -> Delete project. Use also the better
fitting 'edit-delete.svgicon instead of thegear.svg` icon.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copying the behavior from project -> Delete project. Use also the better
fitting 'edit-delete.svg` icon instead of the `gear.svg` icon.
@fredg02 fredg02 requested a review from a team as a code owner June 4, 2022 18:07
@fredg02
Copy link
Member Author

fredg02 commented Jun 4, 2022

Thanks for the review. I'll fix this.

@NotMyFault NotMyFault self-requested a review June 5, 2022 21:45
ADMINISTER permissions are required for now
@fredg02
Copy link
Member Author

fredg02 commented Jun 6, 2022

I have not found a way to make the action work with MANAGE permissions yet, so I've set all the checks to ADMINISTER explicitly to avoid confusion.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, looks great so far!

@NotMyFault NotMyFault merged commit 39c52a2 into jenkinsci:master Jun 7, 2022
@fredg02 fredg02 deleted the dev_no_page_transition branch June 7, 2022 11:57
@fredg02
Copy link
Member Author

fredg02 commented Jun 7, 2022

Thanks for the fast turn-around.👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants