Order list of rake installations for the dropdown #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins » rake-plugin #4 SUCCESS |
| @Override | ||
| public int compareTo(RubyInstallation other){ | ||
| int last = this.name.compareTo(other.name); | ||
| return last == 0 ? this.name.compareTo(other.name) : last; |
There was a problem hiding this comment.
Isn't the second call to compareTo() redundant, especially since name is immutable? In other words, why couldn't we simply return last?
There was a problem hiding this comment.
good point! I will change that.
- This change removes the redundation call to String compareTo - It also adds a test for the compare to function
|
For some reason the pull request is not picking up my latest commit on my source branch. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » rake-plugin #5 SUCCESS |
|
plugins » rake-plugin #6 SUCCESS |
olivierdagenais
added a commit
that referenced
this pull request
Mar 13, 2014
Order list of rake installations for the dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.