Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use bundle exec #17

Merged
merged 1 commit into from
Mar 13, 2014

Conversation

sanelson2000
Copy link
Contributor

This PR adds a checkbox to the task to use bundle exec. It follows all of the same ruby path lookup rules as the actual rake command and will result in a command that looks something like this:

/rubyhome/bin/bundle(.bat) exec rake task

@cloudbees-pull-request-builder

plugins » rake-plugin #7 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@cloudbees-pull-request-builder

plugins » rake-plugin #11 SUCCESS
This pull request looks good

@sanelson2000
Copy link
Contributor Author

I updated the PR using spaces instead of tabs as requested by @olivierdagenais. NOTE: config.jelly is littered with a bunch of tab characters not related to my changes. I only changed the lines that I edited to avoid confusion on the commit.

@olivierdagenais
Copy link
Member

OK, please move the if (bundleExec) block and delete the unused methods and we're good to go.

@cloudbees-pull-request-builder

plugins » rake-plugin #12 SUCCESS
This pull request looks good

@sanelson2000
Copy link
Contributor Author

OK. Done.

olivierdagenais added a commit that referenced this pull request Mar 13, 2014
Add option to use bundle exec
@olivierdagenais olivierdagenais merged commit 247f3ea into jenkinsci:master Mar 13, 2014
@olivierdagenais
Copy link
Member

Thanks for the pull request and your patience! :)

@sanelson2000
Copy link
Contributor Author

No problem. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants