Fix using global gemset's Rake gem #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prevent adding an empty path separator at the front of the GEM PATH and add some debug lines to stdout
| @@ -120,12 +120,15 @@ public class Rake extends Builder { | |||
| try { | |||
| EnvVars env = build.getEnvironment(listener); | |||
| if (rake != null) { | |||
| System.out.println("Rake GEM HOME: "+ rake.getGemHome()); | |||
There was a problem hiding this comment.
Ben could you remove all these logging lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue with the Rake plugin not properly detecting and setting the PATH when using gemsets that inherited the Rake gem from global. This patch attempts to detect the Rake plugin and update the gemBinPath accordingly.