[JENKINS-41513] Prevent NPE in JnlpAgentEndpointResolver #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan 27, 2017 9:15:35 AM hudson.remoting.jnlp.Main$CuiListener error SEVERE: null java.lang.NullPointerException at org.jenkinsci.remoting.engine.JnlpAgentEndpointResolver.header(JnlpAgentEndpointResolver.java:431) at org.jenkinsci.remoting.engine.JnlpAgentEndpointResolver.resolve(JnlpAgentEndpointResolver.java:163) at hudson.remoting.Engine.innerRun(Engine.java:335) at hudson.remoting.Engine.run(Engine.java:287)
|
Please create a bug in JIRA and use @reviewbybees
…On Fri, 27 Jan 2017 at 03:31, Carlos Sanchez ***@***.***> wrote:
Jan 27, 2017 9:15:35 AM hudson.remoting.jnlp.Main$CuiListener error
SEVERE: null
java.lang.NullPointerException
at org.jenkinsci.remoting.engine.JnlpAgentEndpointResolver.header(JnlpAgentEndpointResolver.java:431)
at org.jenkinsci.remoting.engine.JnlpAgentEndpointResolver.resolve(JnlpAgentEndpointResolver.java:163)
at hudson.remoting.Engine.innerRun(Engine.java:335)
at hudson.remoting.Engine.run(Engine.java:287)
------------------------------
You can view, comment on, or merge this pull request online at:
#144
Commit Summary
- Prevent NPE
File Changes
- *M*
src/main/java/org/jenkinsci/remoting/engine/JnlpAgentEndpointResolver.java
<https://github.com/jenkinsci/remoting/pull/144/files#diff-0> (2)
Patch Links:
- https://github.com/jenkinsci/remoting/pull/144.patch
- https://github.com/jenkinsci/remoting/pull/144.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#144>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoKkInWfZC59K1fie2IbARpGbYUxiks5rWbmJgaJpZM4Lvklh>
.
|
carlossg
changed the title
|
🐝 |
oleg-nenashev
approved these changes
Jan 31, 2017
There was a problem hiding this comment.
I doubt that null header is not the case we really want to use anywhere in remoting. So such patch is fine even though this private method does not allow to retrieve null anymore.
The logic of the line below is also broken, because it should retrieve headerField instead of the headerName, which may have a wrong case
|
CC @daniel-beck regarding the use of @reviewbybees done anyway |
|
Closing in favor of #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-41513
@reviewbybees