Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[JENKINS-46515] exit the Launcher process on 4XX errors #193
I share Oleg's concern here. It is weird to exit without warnings and with a zero exit code. This may help in some limited situations, but it introduces unusual and dramatic behavior in all situations. As this is intended to introduce a defensive behavior for certain, hard-to-reproduce situations the proposed fix seems too broad.
I would need to understand the situations and how this proposal resolves them better before approving this approach. I would want to see about alternatives.
Forgot about this PR...
@jeffret-b: true, it is weird exiting with a zero exit code but the current situation involves keeping forever a remoting connection attempt if the Computer at the Jenkins master has been erased.
Terminating the connection reattempts on a 404 seems safe to me (disregarding the exit status value)