Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBytes(Charset) don’t throw exception #234

Merged
merged 1 commit into from
Nov 27, 2017
Merged

getBytes(Charset) don’t throw exception #234

merged 1 commit into from
Nov 27, 2017

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 21, 2017

No description provided.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Nov 21, 2017

I would keep "UTF-8" in the PREAMBLE. It does not matter much in the case of this case, but I would prefer to keep UTF-8 strict so that it's aligned with encoding in the handshake logic:

DataOutputStream outputStream = state.getDataOutputStream();
outputStream.writeUTF(PROTOCOL_PREFIX + getName());
outputStream.writeUTF(o.toString("UTF-8"));
outputStream.flush();

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change is required

@oleg-nenashev
Copy link
Member

@ndeloof When one does force pushes, GitHub does not notify about new commits :(

@oleg-nenashev oleg-nenashev merged commit d5db382 into jenkinsci:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants