Cleanup #367
Cleanup #367
Conversation
| @@ -1865,7 +1916,7 @@ public static void dumpDiagnosticsForAll(@Nonnull PrintWriter w) { | |||
| * Notification that {@link Command#readFrom} has succeeded. | |||
| * @param cmd the resulting command | |||
| * @param blockSize the serialized size of the command | |||
| * @see CommandListener | |||
There was a problem hiding this comment.
IntelliJ and everything else, myself included, were absolutely confused about this reference.
| @@ -57,14 +57,14 @@ public ReaderThread(CommandReceiver receiver) { | |||
| public void run() { | |||
| final String name =channel.getName(); | |||
| try { | |||
| while(!channel.isInClosed()) { | |||
| while (!channel.isInClosed()) { | |||
There was a problem hiding this comment.
These whitespace changes were enforced by IntelliJ when I made an unrelated debugging change (which is not included in this PR).
| @@ -1618,7 +1665,9 @@ public OutputStream getUnderlyingOutput() { | |||
| * The remote port that the connection will be forwarded to. | |||
| * @return | |||
| * Created {@link PortForwarder} | |||
| * @deprecated as of 3.39 | |||
There was a problem hiding this comment.
The PortForwarder class was Deprecated in #361, but no one bubbled up the deprecation within this module.
@jvz @jeffret-b
| .withRestricted(restricted), transport); | ||
| .withArbitraryCallableAllowed(!restricted) | ||
| .withRemoteClassLoadingAllowed(!restricted) | ||
| , transport); |
There was a problem hiding this comment.
This style is used elsewhere within this file.
| * @since 2.13 | ||
| */ | ||
| @Deprecated | ||
| public Channel(String name, ExecutorService exec, CommandTransport transport, boolean restricted, ClassLoader base) throws IOException { | ||
| this(new ChannelBuilder(name,exec) | ||
| .withBaseLoader(base) | ||
| .withRestricted(restricted), transport); |
There was a problem hiding this comment.
withRestricted is deprecated.
jsoref
force-pushed
the
cleanup
branch
2 times, most recently
from
669e7bf
to
a77585a
Compare
|
I'm not sure why Jenkins doesn't like my PRs of late. The changes here are really trivial. They should pass tests. I'm going to force push a couple of times until I have a sense of what's going on. Please don't review until I've figured out what's going on. |
|
I'm done pushing to this PR. There was nothing wrong w/ any of my commits, the CI was flaky. |
|
Thanks for the PRs. It will probably be a few days before I can get to them. Anyone else is also welcome to review. |
jeffret-b
added
chore
While working on jenkinsci/jenkins#4407 (comment), I made a mistake in not recognizing that the default
withModeis different betweenChannel(...)andChannelBuilder(...).I'm not absolutely certain about my comments, but if they're correct, it would help the next person like me perform a similar migration.