Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an override attribute exists in pom.xml file since the related issue had been already fixed. #390

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

markxiaotao
Copy link
Contributor

According to the link https://issues.apache.org/jira/browse/MJARSIGNER-53, I observed that such issue had already been fixed. And based on the comment "Remove once it's in upstream". This override attribute is not needed.

The override attribute and comment:

remoting/pom.xml

Lines 74 to 75 in 0860f22

<!-- TODO: Required to override by a version with certchain support (MJARSIGNER-53) on @oleg-nenashev's machine. Remove once it's in upstream -->
<maven-jarsigner-plugin.version>1.4</maven-jarsigner-plugin.version>

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission and fixing this outdated bit.

@jeffret-b jeffret-b added the chore For changelog: A maintenance chore with no functional changes label Jul 13, 2020
@jeffret-b jeffret-b merged commit 911aaf6 into jenkinsci:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For changelog: A maintenance chore with no functional changes
Projects
None yet
4 participants