Add protection against missing trailing slashes when using websocket. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffret-b
approved these changes
Jul 23, 2020
|
Pinging @jglick since he did the WebSocket work to see if he has any concerns. |
|
I'll release this when I get a chance but it will be a while. |
|
No worries, it's not blocking us. Thanks for including it. |
res0nance
approved these changes
Sep 15, 2020
|
ping @jeffret-b |
|
I'm going to spend a bit of time on maintenance here this week, going through PRs, reviewing, merging where I can, and getting out a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if -webSocket is set and -url does not have a trailing slash, connection will fail with an UnresolvedAddressException. This can prove confusing to diagnose and resolve.
This PR adds a check for a trailing slash and adds it if missing.