Update to parent 1.63. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update is simple, but there's an interesting new findsecbugs pattern, IMPROPER_UNICODE. The behavior can be pretty devious. But, here we're getting the comparison values from the controller, hardcoded, or from the user/admin at launch. We have to trust these sources.
Alternatively we could drop the case-insensitive comparisons. It's possible that could cause a regression, though it's pretty unlikely.
Also update access-modifier-annotation to 1.21 in this PR because there's a dependency relationship via enforcer.