Migrate from SettableFuture to CompletableFuture in tests

[basil]

According to this guide, SettableFuture.create() can be replaced with Java 8's new CompletableFuture(). I did so for any test code that used SettableFuture. Note that modifying usages of SettableFuture in non-test code has binary compatibility implications, so I did not touch non-test code in order to eliminate any risk of regression.

[oleg-nenashev]

Looks good to me, esp. since there are no production code changes

[oleg-nenashev]

Hi @jeffret-b . Would you be fine if I start merging some of the Remoting pull requests?

[jeffret-bg]

@oleg-nenashev Because of the complex nature of testing and fully releasing / integrating Remoting I prefer a different approach. I've found it to work better when dealing with releases.

When a PR is ready, I mark it as ready-to-merge. That means it's sufficiently reviewed and tested and doesn't currently have any outstanding concerns. There are currently two PRs marked that way.

Then when I get ready to collect things into a release I pick up one or more ready-to-merge PRs, merge them in, and then start running through the testing and release cycle.

I've found a number of times where there was a higher priority change that came in later that needed to get out before another, less reliable change.

So, go ahead and mark things ready-to-merge.

I've thought about trying to get things assembled for a release. Not sure I would get to that this week. If someone else wants to help put things together for a release, that would be fine.

[jeffret-b]

Looks good. Thanks for the submission. Nice cleanup.