Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the url of HudsonArch-Remoting.pdf #447

Merged
merged 1 commit into from
May 1, 2021

Conversation

donhui
Copy link
Member

@donhui donhui commented Apr 30, 2021

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Update the url of HudsonArch-Remoting.pdf, because hudson-ci.org cannot be accessed.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the update itself. At the same time the slidedeck is quite old. While still useful for the JNLP4-connect protocol and Jenkins RMI parts, it does not represent newer connection modes (websockets, Remoting over Apache Kafka). It also uses the deprecated terminology. Ideally we should replace the document by a more modern architecture overview.

I have an old https://speakerdeck.com/onenashev/day-of-jenkins-2017-dealing-with-agent-connectivity-issues slidedeck with some architecture references. We also made a "Scaling Network Connections from the Jenkins controller" talk together with @jglick with some insight(video). These talks do not really qualify as architecture overview replacing this old deck

@donhui
Copy link
Member Author

donhui commented Apr 30, 2021

@oleg-nenashev The slide and video you mentioned are very useful for one who want to know more about remoting. It is really great!

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The middle section is indeed specific to TCP transport. OTOH the WebSocket transport is conceptually much simpler (there is not a lot to say about it), and the beginning and final sections are independent of transport and remain valid descriptions.

@oleg-nenashev oleg-nenashev merged commit 8b6b46f into jenkinsci:master May 1, 2021
@oleg-nenashev
Copy link
Member

Thanks for the patch @donhui ! Any contributions are welcome and much appreciated. I will try to spend some time and to add materials I know about

@donhui donhui deleted the patch-1 branch May 6, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants