[JENKINS-40700] Enable Launcher to hold the communication protocol. #452
Conversation
oleg-nenashev
added
the
enhancement
There was a problem hiding this comment.
Thanks! It would be nice to add it. At the same time, Javadoc for this and for #450 methods are needed IMHO
| @@ -787,6 +790,10 @@ public static boolean isWindows() { | |||
| return File.pathSeparatorChar==';'; | |||
| } | |||
|
|
|||
| public static String getCommunicationProtocol() { | |||
There was a problem hiding this comment.
Could you please add Javadoc to this method and to getProtocolName()? They are very close, and disambiguation is needed. Also, it could be a "getCommunicationProtocolName"
There was a problem hiding this comment.
I understand. Thank you for reviewing!
|
[Resolved] The CI process for Windows has been canceled but the error log seems unrelated to my changes. Do you have any ideas? Log message: Cannot contact EC2 (aws) - Windows 2019 (i-09a1c08cae6665e79): hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@40d5902d:EC2 (aws) - Windows 2019 (i-09a1c08cae6665e79)": Remote call on EC2 (aws) - Windows 2019 (i-09a1c08cae6665e79) failed. The channel is closing down or has closed down link: https://ci.jenkins.io/blue/organizations/jenkins/Core%2Fremoting/detail/PR-452/2/pipeline/ |
Save the communication protocol when the channel is established and provide the protocol name via `getCommunicationProtocolName`.
|
I got it. Thank you for your help! |
|
Thanks for the patch @Aki-7 ! |
I'm working on the ticket below.
[JENKINS-40700] Display communication protocol in agent logs
And this is the continuation of #450.
#450 enables the current Engine to hold the name of the using communication protocol such as
JNLP4-connect.This PR enables Launcher to hold communication protocol name such as
TCP (remote: client)orStandard in/outI submitted the PR that uses this feature on the controller side to jenkinsci / jenkins.
link: jenkinsci/jenkins#5459