Support junit 5; Migrate non-forked junit 3 test cases #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate existing junit 3 tests to junit 5 with standard ParameterizedTest facility This uses @MethodSource providing the various ChannelRunner instances used for testing. Migrated existing assert/assume calls impacted tests to the new jupiter api. Overall this covers more combinations than the previous framework as some of them were actually not covered previously for some reason. Keeping existing junit 3 test cases from forked packages as the proper approach here would rather be to pull new versions.
jglick
reviewed
Oct 13, 2022
~50% flake locally if I recall properly. |
jglick
approved these changes
Oct 13, 2022
|
|
||
| final ExecutionException e = assertThrows(ExecutionException.class, f::get); | ||
| assertThat(e.getCause(), instanceOf(IOException.class)); | ||
| final ExecutionException e = assertThrows(ExecutionException.class, () -> f.get(2, TimeUnit.SECONDS)); |
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
|
Seems |
|
Do you plan to look into #593 (comment), or shall I just merge this as is? |
|
Added a timeout, I don't plan to investigate more time into the hanging test. |
|
ca83285 did not work it seems: |
|
Maybe it worked so far as it went, but each test method gets run up to five times, and there are up to six parameter values, so spending a minute on each run in the worst case can be a lot. Hmm, but it seems that by default timeouts are not preëmptive—if you exceed the timeout (but the method completes), the test fails, but that is no good for ensuring CI completes in time. |
|
Some really weird stuff like |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate existing junit 3 tests to junit 5 with standard
ParameterizedTestfacilityThis uses
@MethodSourceproviding the various ChannelRunner instances used for testing.Migrated existing assert/assume calls impacted tests to the new jupiter api.
Overall this covers more combinations than the previous framework as some of them were actually not covered previously for some reason, even though they were extending
RmiTestBase.Keeping existing junit 3 test cases from forked packages as the proper approach here would rather be to pull new versions.