Print deprecation warning when deprecated arguments are used #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
added
the
enhancement
MarkEWaite
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I have migrated common usages away from these deprecated arguments, ensure that a warning is printed if a user is still invoking Remoting with a deprecated argument. I haven't yet added a warning for
-jnlpUrlbecause I want to wait for jenkinsci/jenkins#8639 to ship in a few weekly releases first. The-tcpand-connectToarguments weren't deprecated at the command-line argument level but their implementations were marked with@Deprecated, so I am deprecating the command-line arguments too for consistency. I could find no uses besides the WMI Windows Agents plugin tests, and that plugin is itself already deprecated.Testing done
Invoked the various arguments at the command-line and verified that a deprecation warning was printed.