RobotParser: handle empty arguments tags #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old versions of RF, e.g. Robot 2.8.5 (Python 2.7.9 on linux2), can produce an output file with empty "arguments" tags, i.e. no arg child. Parsing such file would break as ignoreUntilStarts would throw an exception due to not finding the arg starting tag. This fix replace usage of ignoreUntilStarts to a more manual parsing to handle this case.
|
Hi! |
|
Hi @dece The unit tests seem to fail https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Frobot-plugin/detail/PR-31/1/pipeline/#step-31-log-314, care to take a look? EDIT: Nevermind, I already took care of that. |
|
Hi! Thank you for the edit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of RF, e.g. Robot 2.8.5 (Python 2.7.9 on linux2), can produce an output file with empty "arguments" tags, i.e. no arg child. Parsing such file would break as ignoreUntilStarts would throw an exception due to not finding the arg starting tag.
This fix replace usage of ignoreUntilStarts to a more manual parsing to handle this case.