Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission.fromId is now @CheckForNull. #2

Merged
merged 2 commits into from Jul 7, 2013

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 4, 2013

A user reported an exception likely caused by a permission defined in a now-disabled plugin:

java.lang.NullPointerException 
        at com.michelin.cio.hudson.plugins.rolestrategy.RoleBasedAuthorizationStrategy$ConverterImpl.marshal(RoleBasedAuthorizationStrategy.java:245)

(Line numbers are as in #1.)

@buildhive
Copy link

Jenkins » role-strategy-plugin #4 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

Jenkins » role-strategy-plugin #5 SUCCESS
This pull request looks good
(what's this?)

@oleg-nenashev
Copy link
Member

Hello Jesse,

I’m going to merge all pull requests to this plugin.

My pull request requires at least 1.473 version of the core (#3). Is 1.420 version significant to you? If yes, I’ll publish additional version with your changes only.

BR, Oleg Nenashev

oleg-nenashev added a commit that referenced this pull request Jul 7, 2013
@oleg-nenashev oleg-nenashev merged commit 8ba15e7 into jenkinsci:master Jul 7, 2013
@jglick
Copy link
Member Author

jglick commented Aug 1, 2013

1.420 was merely the earliest parent POM version which allows compilation from JDK 7.

@jglick jglick deleted the unmarshal-null branch August 1, 2013 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants