Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][JENKINS-58293] Folder based Authorization as a new AuthorizationStrategy #89

Closed
wants to merge 25 commits into from
Closed

[WIP][JENKINS-58293] Folder based Authorization as a new AuthorizationStrategy #89

wants to merge 25 commits into from

Commits on Jul 2, 2019

  1. [WIP] Folder based Authorization as a new AuthorizationStrategy

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    7ea9bad View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Add GlobalRole implementation for folders

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    a02ea97 View commit details
    Browse the repository at this point in the history

  2. Fix GlobalAclImpl's behaviour and add unit test for it

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    15d7222 View commit details
    Browse the repository at this point in the history

  3. Add a basic Jelly view to add global role from browser 

    The POST request is currently not handled properly
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    82de631 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Adding global roles now works from the Web UI

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    b70972a View commit details
    Browse the repository at this point in the history

  2. Cleanup code

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    1b35cd1 View commit details
    Browse the repository at this point in the history

  3. Fix Findbugs warnings and improve the UI

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    b3e97b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Allow assigning sids to global roles from web UI 

    * Also remove `forEach` from JavaScript as it is not compatible with
old browsers
* Make the dependency on Cloudbees folder plugin optional
* Update Jelly UI
* Make GlobalRoleCreationRequest `@Restricted(NoExternalUse.class)`
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    5043e0c View commit details
    Browse the repository at this point in the history

  2. Add a wrapper for Permission to make config.xml smaller

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    0abbc87 View commit details
    Browse the repository at this point in the history

  3. Git ignore .factorypath

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    cdd82e1 View commit details
    Browse the repository at this point in the history

  4. Fix GlobalAclImplTest and add utility method to wrap up Permissions

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    cee8c32 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Implement basic folder authorization 

    * Refactor roles and ACLs into their own packages
* Update the Jelly UI a bit
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    4a61f8b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Allow adding FolderRoles from web UI

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    e9babe7 View commit details
    Browse the repository at this point in the history

  2. Fix JavaDoc

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    e3bdf1f View commit details
    Browse the repository at this point in the history

  3. Allow assigning FolderRoles to Sids from Web UI

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    a518384 View commit details
    Browse the repository at this point in the history

  4. Add a unit test for FolderBasedAuthorizationStrategy

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    c11e7ae View commit details
    Browse the repository at this point in the history

  5. Use JavaScript to submit 'Add folder role' form

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    359ef9f View commit details
    Browse the repository at this point in the history

  6. Make Jelly UI look less bad

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    a5deb46 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Whitelist java.util.concurrent.ConcurrentHashMap$KeySetView

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    2853ca5 View commit details
    Browse the repository at this point in the history

  2. Allow deleting global and folder roles 

    * Also add docs to globalrole.js
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    20f6657 View commit details
    Browse the repository at this point in the history

  3. Add administrator checks to deleting roles

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    5fe72ef View commit details
    Browse the repository at this point in the history

  4. Cache ACLs that contain inheritance data

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    7e18738 View commit details
    Browse the repository at this point in the history

  5. Throw errors instead of not doing anything 

    * Also make AbstractRole `@Restricted(NoExternalUse.class)`
* Add some JavaDoc
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    73956b6 View commit details
    Browse the repository at this point in the history

  6. Disallow dangerous permissions

    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    bf50316 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Add Support for Configuration-as-Code 

    * Use the CasC incremental
* Use AbstractFolders instead of Folders
    @AbhyudayaSharma
    AbhyudayaSharma committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    ce4ada2 View commit details
    Browse the repository at this point in the history