Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-26005] - Modify the constructor of RunConditionEmailTrigger to call the non-depre... #1

Merged
merged 1 commit into from Apr 29, 2015

Conversation

sullivac
Copy link

...cated constructor.

The constructor that passes boolean parameters for the "Send To" list has been deprecated as 2.38 (email-ext.)
Fix for JENKINS-26005.

@oleg-nenashev
Copy link
Member

@sullivac
No objections regarding the upgrade.
BTW, the original constructor should be left for the sake of the backward compatibility. You can just mark it as deprecated and mention the reason in Javadoc.

…precated constructor.

    The constructor that passes boolean parameters for the "Send To" list has been deprecated as 2.38 (email-ext.)
    Fix for JENKINS-26005.
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev oleg-nenashev changed the title Modify the constructor of RunConditionEmailTrigger to call the non-depre... [FIXED JENKINS-26005] - Modify the constructor of RunConditionEmailTrigger to call the non-depre... Apr 29, 2015
@@ -63,7 +76,7 @@ public boolean trigger(AbstractBuild<?, ?> ab, TaskListener tl) {
logError(tl, Messages.RunConditionEmailTrigger_listenerClassConvError());
return false;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the future... Please avoid formatting changes in bugfixes

oleg-nenashev added a commit that referenced this pull request Apr 29, 2015
[FIXED JENKINS-26005] - Modify the constructor of RunConditionEmailTrigger to call the non-depre...
@oleg-nenashev oleg-nenashev merged commit 9ff4683 into jenkinsci:master Apr 29, 2015
@oleg-nenashev
Copy link
Member

I'll try to kick-off the release on this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants