Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-68471] Prepare SAML for removal of JAXB and Java 11 requirement #206

Merged
merged 1 commit into from May 10, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 10, 2022

See JENKINS-68471. This plugin depends on org.pac4j:pac4j-saml, which depends on org.pac4j:pac4j-saml, which depends on org.opensaml:opensaml-security-api, which depends on org.apache.santuario:xmlsec, which depends on JAXB:

org.jenkins-ci.plugins:saml:hpi:2.999999-SNAPSHOT
+- org.pac4j:pac4j-saml:jar:3.9.0:compile
|  +- org.opensaml:opensaml-security-api:jar:3.4.3:compile
|  |  +- org.apache.santuario:xmlsec:jar:2.3.0:compile
|  |  |  +- JAXB

But when running on Java 9+, JAXB is not included on the classpath by default. The only way for a plugin to have access to JAXB when running on Jenkins 2.164 or later on Java 11 is to declare a plugin-to-plugin dependency on JAXB API plugin (recommended) or to embed JAXB into its .jpi file. This PR does the former to ensure that SAML always has access to JAXB on its classpath. CC @kuisathaverat

@kuisathaverat
Copy link

It is weird I did not detect it on any of the issues I have troubleshooting at https://github.com/kuisathaverat/jenkins-issues it is been a while since I use JDK 11, in any case, seems fair to include the dependency.

@kuisathaverat kuisathaverat merged commit 1adff8e into jenkinsci:main May 10, 2022
@basil basil deleted the JENKINS-68471 branch May 10, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants