Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent, modern action icons #207

Merged
merged 2 commits into from Feb 10, 2023
Merged

Use consistent, modern action icons #207

merged 2 commits into from Feb 10, 2023

Conversation

cronik
Copy link
Contributor

@cronik cronik commented Feb 9, 2023 •
edited by MarkEWaite

Use Jenkins design library icons.

Screenshot 2023-02-09 at 6 16 01 PM

Screenshot 2023-02-09 at 6 16 34 PM

Checklist

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • New feature (non-breaking change which adds functionality)

MarkEWaite
MarkEWaite requested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

Could you either delete the failing testGetIconFileName or update it so that it passes? I'm OK with either a deletion or an update.

@cronik
Update action icons
f4fa361 
Use Jenkins design library icons.
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Feb 10, 2023
@MarkEWaite MarkEWaite self-requested a review February 10, 2023 00:44
MarkEWaite
MarkEWaite approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 10, 2023
@MarkEWaite MarkEWaite removed the documentation Improvements or additions to documentation label Feb 10, 2023
@MarkEWaite
Copy link
Contributor

I've updated the documentation page with the images that you included in the pull request. Thanks again!

@MarkEWaite MarkEWaite changed the title Update action icons Use consistent, modern action icons Feb 10, 2023
@MarkEWaite MarkEWaite merged commit a7540f6 into jenkinsci:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
2 participants
@cronik @MarkEWaite