Adapt plugin for Java 21 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
Java 21 changed the date format to use a narrow no-break space, so the regular expression used in the tests now fails to match. Changed the test to use the '\h' character class, which matches. jenkinsci/token-macro-plugin#191 uses the same technique to handle test compatibility between Java 11, Java 17, and Java 21.
Java 21 changed the behavior of the DateFormat parsing to no longer accept strings that contain only a time. Previous versions of Java would default to January 1, 1970 if no date value was specified. The Java 21 behavior is quite reasonable, since a Date specifies a number of milliseconds since the epoch, not an offset since the start of the day. The plugin misuses a Date object to represent what Java 8 declared as LocalTime, a representation of time within a day. This change continues with the previous behavior, checking a DateFormat first. If the DateFormat parse fails, then it iterates through a series of DateTimeFormatter patterns to check if the passed string matches one of those formats. I've not detected any case in the typical use of the plugin where the new Java 21 behavior affects plugin behavior. It seems that there should be cases where the change is relevant, but I was not able to detect any of those cases.
Same parsers are needed in the action class, but there are not yet any failing tests to show how they might help.
MarkEWaite
added
bugfix
and removed
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-71817 - Adapt plugin for Java 21
The Java 21
DateFormatclass will not parse strings that contain only a time component without a date component. The plugin relies on the earlier Java behavior of parsing "10:00:00 PM" into a DateFormat for today. That's a bad assumption that the plugin was making, but the assumption exists and users may be relying on the assumption.Java 21 date string output has changed from a space character to a Unicode short space character. That change required some test changes. jenkinsci/token-macro-plugin#191 shows a technique to handle that portably across multiple Java versions.
Checklist
Types of changes
Further comments
More changes are required before this pull request can be considered. Automated tests are failing due to unparseable date.