Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-42000] ProjectObserver.complete should be allowed to throw IOException #29

Merged
merged 1 commit into from Feb 14, 2017
Merged

[JENKINS-42000] ProjectObserver.complete should be allowed to throw IOException #29

merged 1 commit into from Feb 14, 2017

Conversation

stephenc
Copy link
Member

  • While technically a binary incompatibility, as all call sites except for OrganizationFolder already declare throwing IOException this should be safe

See JENKINS-42000

@reviewbybees

@stephenc
[JENKINS-42000] ProjectObserver.complete should be allowed to throw I…
b4b7b67 
…OException

- While technically a binary incompatibility, as all call sites except for OrganizationFolder already declare throwing IOException this should be safe
This was referenced Feb 14, 2017
Merged
Merged
jglick
jglick approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is even binary compatible. The JVM does not care about checked exceptions.

@stephenc stephenc merged commit 563db93 into jenkinsci:master Feb 14, 2017
@stephenc stephenc deleted the jenkins-42000 branch February 14, 2017 21:28
@stephenc stephenc restored the jenkins-42000 branch February 14, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stephenc @jglick