This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Fixes for scp plugin #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue JENKINS-21138 An exception occurs during console log upload causing only partial logs to be copied to the remote server. The problem is that the session object is not thread safe. To fix this problem we need to move the session object into the ConsoleRunnable thread. Now the console upload always runs in a completely detached thread. Notes: 1. Needed to update jenkins version to 1.430 because 1.403 would not build anymore. I think 1.430 should be conservative enought to be compatible with most of the existing jenkins installs. 2. Updated com.jcraft.jsch depenency to version 1.50
This commit does the following: 1. fix to only create a single session if the scp plugin is configured to copy only the console log and no other files. 2. Give createOutStream a logger.
In certain conditions the scp plugin may run to completion before the console log file even gets created on the remote scp site. This commit adds a syncronization point to make sure the console log file gets created before the main scp thread exits.
|
plugins » scp-plugin #7 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » scp-plugin #8 SUCCESS |
Closed
It is possible for child thread to hang due to exceptions occurring before a notify to the parent thread. To prevent execution from hanging the child thread will notify parent thread no matter what happens.
|
plugins » scp-plugin #9 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue JENKINS-21138
An exception occurs during console log upload causing only partial logs
to be copied to the remote server. The problem is that the session object
is not thread safe. To fix this problem we need to move the session
object into the ConsoleRunnable thread. Now the console upload always
runs in a completely detached thread.
Notes:
anymore. I think 1.430 should be conservative enought to be compatible
with most of the existing jenkins installs.
before creating the console log file on the remote server.